Cutieguwu/miller
Archived
1
0
Fork 0
Code Issues 39 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Switch Event::team method return to Option instead of Result<Team, error::NoTeamAttribute> #17

New Issue
Closed
opened 2025-04-23 19:42:53 -04:00 by Cutieguwu · 1 comment
Cutieguwu commented 2025-04-23 19:42:53 -04:00 (Migrated from github.com)
Copy Link

There is no need for an error result here, and it breaks consistency with Event::delta() and Event::quarter().

error::NoTeamAttribute should be deprecated, and Event::team should instead return Option<Team>.

There is no need for an error result here, and it breaks consistency with `Event::delta()` and `Event::quarter()`. `error::NoTeamAttribute` should be deprecated, and `Event::team` should instead return `Option<Team>`.
Cutieguwu commented 2025-04-23 20:34:21 -04:00 (Migrated from github.com)
Copy Link

Resolved in a5535354a3

Resolved in a5535354a33a0b203a83105b3a73970db9009657
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
backend
Something to do with the backend
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 invalid
This doesn't seem right
 rust
Pull requests that update rust code
 tui
Something to do with the TUI
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Cutieguwu
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cutieguwu/miller#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?