From b1093e9da5f27253f3db692352daf5cf4ad5b98d Mon Sep 17 00:00:00 2001
From: Trent Piepho <35062987+xyzzy42@users.noreply.github.com>
Date: Fri, 26 Jun 2026 06:20:10 -0700
Subject: [PATCH] Fix VERBOSE make flag (#26289)

The docs say set this to true to enable verbose output, but setting it to
anything, even "false", would enable verbose mode.

The qmk python build program actually does this, supplying "VERBOSE=false"
to make, which turns verbose mode on, not off!  The reason it's not verbose
is that the wrapper also adds the "-s" switch that has the same effect as
turning verbose mode back off.

After fixing the flag, there's no reason to add the "-s", so remove that code.
---
 Makefile                        | 2 +-
 builddefs/build_keyboard.mk     | 2 +-
 builddefs/build_test.mk         | 2 +-
 lib/python/qmk/build_targets.py | 3 ---
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 2a992845ce1..2dbb085f96a 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-ifndef VERBOSE
+ifneq ($(VERBOSE),true)
 .SILENT:
 endif
 
diff --git a/builddefs/build_keyboard.mk b/builddefs/build_keyboard.mk
index acfad61e7d1..50411e952a8 100644
--- a/builddefs/build_keyboard.mk
+++ b/builddefs/build_keyboard.mk
@@ -4,7 +4,7 @@
 # responsible for determining which folder is being used and doing the
 # corresponding environment setup.
 
-ifndef VERBOSE
+ifneq ($(VERBOSE),true)
 .SILENT:
 endif
 
diff --git a/builddefs/build_test.mk b/builddefs/build_test.mk
index ccdad1b4e79..1f1a9fbea83 100644
--- a/builddefs/build_test.mk
+++ b/builddefs/build_test.mk
@@ -1,4 +1,4 @@
-ifndef VERBOSE
+ifneq ($(VERBOSE),true)
 .SILENT:
 endif
 
diff --git a/lib/python/qmk/build_targets.py b/lib/python/qmk/build_targets.py
index 35a5f89f91a..1d4f82c767c 100644
--- a/lib/python/qmk/build_targets.py
+++ b/lib/python/qmk/build_targets.py
@@ -113,9 +113,6 @@ class BuildTarget:
             'builddefs/build_keyboard.mk',
         ]
 
-        if not cli.config.general.verbose:
-            compile_args.append('-s')
-
         verbose = 'true' if cli.config.general.verbose else 'false'
         color = 'true' if cli.config.general.color else 'false'