Cutieguwu/qmk_firmware-mirror
1
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2026-07-12 20:06:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix VERBOSE make flag (#26289)

Browse Source 
The docs say set this to true to enable verbose output, but setting it to
anything, even "false", would enable verbose mode.

The qmk python build program actually does this, supplying "VERBOSE=false"
to make, which turns verbose mode on, not off!  The reason it's not verbose
is that the wrapper also adds the "-s" switch that has the same effect as
turning verbose mode back off.

After fixing the flag, there's no reason to add the "-s", so remove that code.
This commit is contained in:
Trent Piepho
2026-06-26 06:20:10 -07:00
committed by GitHub
parent 0cb6461c6a
commit b1093e9da5
4 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/python/qmk/build_targets.py
-3
View File
@@ -113,9 +113,6 @@ class BuildTarget:
'builddefs/build_keyboard.mk',
]
if not cli.config.general.verbose:
compile_args.append('-s')
verbose = 'true' if cli.config.general.verbose else 'false'
color = 'true' if cli.config.general.color else 'false'