fix: raven test #2

AdrianLong · 2026-01-27T00:05:29-05:00

AdrianLong commented

2026-01-27 00:05:29 -05:00

The error in raven test has to do with incorrect arguments being passed through the command line into java.

current:
java Xms128.0 MiB Xmx512.0 MiB PROJECT_ROOT/src/text

correct:
java -Xms128m -Xmx512m -cp PROJECT_ROOT/src/text \test.Test

Additionally the default classes for assets were wrong. Java does not consider files directly inside of the main and test folders as inside of a package of that folder name.

The error in raven test has to do with incorrect arguments being passed through the command line into java. current: java Xms128.0 MiB Xmx512.0 MiB PROJECT_ROOT/src/text correct: java -Xms128m -Xmx512m -cp PROJECT_ROOT/src/text \test.Test Additionally the default classes for assets were wrong. Java does not consider files directly inside of the main and test folders as inside of a package of that folder name.

AdrianLong added 2 commits 2026-01-27 00:05:29 -05:00

Fixed raven build to build from anywhere inside of a raven project. 27f784e1f0

Refactored assets to use propper java syntax. Found error in the raven test command. Impropper formating when passing arguments to the java command. 7aea79c4fa

Cutieguwu commented

2026-01-27 05:56:55 -05:00

With regards to 27f784e1f0, remember that DIR_SRC uses PROJECT_ROOT to construct itself since dafc6ea885.

You likely have PROJECT_ROOT doubled.

The easiest solution here is to probably expand the ByteSize to a size in bytes as usize, then just append that number. It doesn't need to be human readable. IIRC, -Xms and -Xmx default to bytes if there's no unit suffix.

With regards to 27f784e1f03e6ee6b4e9266ed6bb3ee96a573fff, remember that `DIR_SRC` uses `PROJECT_ROOT` to construct itself since dafc6ea8857e88dce77a7569246e62ad5a9ed60e. You likely have `PROJECT_ROOT` doubled. The easiest solution here is to probably expand the `ByteSize` to a size in bytes as `usize`, then just append that number. It doesn't need to be human readable. IIRC, `-Xms` and `-Xmx` default to bytes if there's no unit suffix.

Cutieguwu requested review from Cutieguwu 2026-01-27 05:58:33 -05:00

Cutieguwu referenced this pull request

2026-01-27 06:00:38 -05:00

`raven test` is totally borked. #3

AdrianLong added 1 commit 2026-01-27 13:40:24 -05:00

Fixed raven test. The raven test system needs to be redesigned in order to run multiple different test classes. Cyclic dependencies cannot be resolved the curent build system so a parser needs to be implemented to get the import statements. 67381eb071

AdrianLong changed title from ~~WIP: master~~ to fix: raven test

2026-01-27 13:42:08 -05:00

Cutieguwu force-pushed master from 67381eb071 to 05390a8f0b

2026-01-27 13:47:59 -05:00

Compare

Cutieguwu commented

2026-01-27 13:54:47 -05:00

Build fails. Cannot remove assets/test/Main.java. Required by include_bytes!() in main.rs, line 150.

Build fails. Cannot remove `assets/test/Main.java`. Required by `include_bytes!()` in `main.rs`, line 150.

Cutieguwu commented

2026-01-27 14:00:56 -05:00

Please also remove the Fences println! in main::test(), java::JVM::run().

Please also remove the Fences `println!` in `main::test()`, `java::JVM::run()`.

Cutieguwu commented

2026-01-27 14:05:37 -05:00

I don't think that the help menu needs to be in README.md, but it can stay at least for now.

There's a reason that there's a help menu that auto-updates with the cli edits. We'd have to remember to manually update the README every time there's a change, or an added command.

I don't think that the help menu needs to be in README.md, but it can stay at least for now. There's a reason that there's a help menu that auto-updates with the cli edits. We'd have to remember to manually update the README every time there's a change, or an added command.

AdrianLong added 1 commit 2026-01-27 14:10:09 -05:00

Removed Fence denugging statements 82b45d9c66

Cutieguwu merged commit 676b0b606b into master

2026-01-27 16:33:42 -05:00

Cutieguwu referenced this issue from a commit

2026-01-27 16:33:43 -05:00

Merge pull request 'fix: raven test' (#2) from AdrianLong/raven:master into master

Cutieguwu declined to review 2026-01-27 16:34:18 -05:00

Sign in to join this conversation.