Code cleanup.

Reviewed-on: #2

AUTHORS.md

@@ -0,0 +1,8 @@
+# Authors
+
+raven was written by Olivia Brooks (Cutieguwu).
+
+Thanks to Adrian Long (Viffx) who contributed a number of PRs including:
+
+- An initial implementation of the project root search
+- Debugging my shitty code many times over

Cargo.toml

@@ -2,23 +2,27 @@
 name = "raven"
 version = "0.1.0"
 edition = "2024"
+authors = ["Olivia Brooks", "Adrian Long"]
+repository = "https://gitea.cutieguwu.ca/Cutieguwu/raven"
+license = "MIT"
+publish = false
 
 [dependencies]
 anyhow = "1.0"
 bytesize = "2.3"
 ron = "0.12"
-sha256 = "1.6.0"
+sha256 = "1.6"
 subprocess = "0.2"
 toml = "0.9"
 
-[dependencies.serde]
-version = "1.0"
-features =["derive"]
-
 [dependencies.clap]
 version = "4.5"
-features = ["derive"]
+features = ["cargo", "derive"]
 
 [dependencies.semver]
 version = "1.0"
 features = ["serde"]
+
+[dependencies.serde]
+version = "1.0"
+features =["derive"]

README.md

@@ -32,12 +32,29 @@ cd demo
 raven run main.Main
 ```
 
+## Raven commands
+Usage: raven <COMMAND>
+
+Commands:
+  new    Create a new raven project
+  init   Create a new raven project in an existing directory
+  build  Compile the current project
+  run    Run the current project
+  test   !!! BORKED !!! Run the tests
+  clean  Remove the target directory and caching
+  help   Print this message or the help of the given subcommand(s)
+
+Options:
+  -h, --help     Print help
+  -V, --version  Print version
+
 ## Future plans
 
-- [ ] Fix `raven test`. Totally borked.
-- [ ] Make `nest run` fall back to an entry point specified in Nest.toml, when
+- [ ] Make `raven run` fall back to an entry point specified in Nest.toml, when
     none provided.
 - [ ] Fix project structure, eliminate inter-dependencies.
   - [ ] Separate out `java.rs` into a dedicated wrapper library.
-- [ ] Possibly add support for pulling remote packages via `nest add`. This
+- [ ] Possibly add support for pulling remote packages via `raven add`. This
     will be implemented should there arise a need.
+- [ ] Wrap errors properly, instead of hap-hazardly using `anyhow`
+- [ ] Maybe proper logging?

assets/src/main/Main.java

@@ -1,5 +1,3 @@
-package main;
-
 public class Main {
 
     public static void main(String[] args) {

assets/src/test/MainTest.java

@@ -1,12 +1,10 @@
-package test;
-
-public class Main {
+public class MainTest {
 
     public static void main(String[] args) {
         testAdd();
     }
 
     public static void testAdd() {
-        assert main.Main.add(2, 2) == 4;
+        assert Main.add(2, 2) == 4;
     }
 }

src/cli.rs

@@ -5,6 +5,8 @@ use clap::{ArgAction, Parser, Subcommand};
 pub static CONFIG: LazyLock<Args> = LazyLock::new(|| Args::parse());
 
 #[derive(Debug, Parser)]
+#[clap(author, version)]
+#[command(help_template = "{author-section}\n{usage-heading} {usage}\n\n{all-args}")]
 pub struct Args {
     #[command(subcommand)]
     pub command: Command,

src/env.rs

@@ -35,10 +35,7 @@ pub fn get_javac_ver() -> anyhow::Result<semver::Version> {
 }
 
 pub fn set_cwd<P: AsRef<Path>>(path: P) -> io::Result<()> {
-    let mut cwd = crate::PROJECT_ROOT
-        .lock()
-        .expect("Failed to lock Mutex")
-        .to_owned();
+    let mut cwd = crate::PROJECT_ROOT.clone();
     cwd.push(path.as_ref());
-    std::env::set_current_dir(cwd)
+    std::env::set_current_dir(cwd.as_path())
 }

src/java.rs

@@ -17,11 +17,15 @@ pub struct JVMBuilder {
     monitor: bool,
     ram_min: Option<ByteSize>,
     ram_max: Option<ByteSize>,
+    class_path: PathBuf,
 }
 
 impl JVMBuilder {
-    pub fn new() -> Self {
-        Self::default()
+    pub fn new<P: AsRef<Path>>(class_path: P) -> Self {
+        Self {
+            class_path: class_path.as_ref().to_path_buf(),
+            ..Default::default()
+        }
     }
 
     pub fn assertions(&mut self, assertions: bool) -> &mut Self {
@@ -46,7 +50,9 @@ impl JVMBuilder {
     }
 
     pub fn build(&self) -> JVM {
-        let mut flags = vec![];
+        let mut flags = vec![VMFlag::Classpath {
+            path: self.class_path.to_owned(),
+        }];
 
         if self.assertions {
             flags.push(VMFlag::EnableAssert);
@@ -85,7 +91,8 @@ impl JVM {
                 .into_iter()
                 .flat_map(|f| Into::<Vec<String>>::into(f)),
         );
-        cmd.push(entry_point.as_ref().display().to_string());
+
+        cmd.push(entry_point.as_ref().to_path_buf().display().to_string());
 
         let result = crate::io::run_process(cmd.as_slice());
 
@@ -110,6 +117,7 @@ impl JVM {
 
 #[derive(Debug, Clone)]
 pub enum VMFlag {
+    Classpath { path: PathBuf },
     EnableAssert,
     HeapMax { size: ByteSize },
     HeapMin { size: ByteSize },
@@ -118,12 +126,10 @@ pub enum VMFlag {
 
 impl Into<Vec<String>> for VMFlag {
     fn into(self) -> Vec<String> {
-        match self {
-            Self::EnableAssert => vec![String::from("-ea")],
-            Self::HeapMax { size } => vec![format!("Xmx{}", size)],
-            Self::HeapMin { size } => vec![format!("Xms{}", size)],
-            Self::Version => vec![String::from("--version")],
-        }
+        self.to_string()
+            .split_ascii_whitespace()
+            .map(|s| s.to_string())
+            .collect()
     }
 }
 
@@ -135,9 +141,10 @@ impl fmt::Display for VMFlag {
             f,
             "-{}",
             match self {
+                Self::Classpath { path } => format!("classpath {}", path.display()),
                 Self::EnableAssert => String::from("ea"),
-                Self::HeapMax { size } => format!("Xmx{}", size),
-                Self::HeapMin { size } => format!("Xms{}", size),
+                Self::HeapMax { size } => format!("Xmx{}", size.as_u64()),
+                Self::HeapMin { size } => format!("Xms{}", size.as_u64()),
                 Self::Version => String::from("-version"), // --version
             }
         )
@@ -213,14 +220,14 @@ impl Compiler {
 
 #[derive(Debug, Clone)]
 pub enum CompilerFlag {
-    Destination { path: PathBuf },
     Classpath { path: PathBuf },
+    Destination { path: PathBuf },
 }
 
 impl Into<Vec<String>> for CompilerFlag {
     fn into(self) -> Vec<String> {
         match self {
-            Self::Classpath { path } => vec!["-cp".to_string(), path.display().to_string()],
+            Self::Classpath { path } => vec!["-classpath".to_string(), path.display().to_string()],
             Self::Destination { path } => vec!["-d".to_string(), path.display().to_string()],
         }
     }

src/main.rs

@@ -8,7 +8,7 @@ mod nest;
 use std::fs::OpenOptions;
 use std::io::{Read, Write};
 use std::path::{Path, PathBuf};
-use std::sync::{LazyLock, Mutex};
+use std::sync::LazyLock;
 
 use cli::{CONFIG, Command};
 use java::{JAVA_EXT_CLASS, JAVA_EXT_SOURCE};
@@ -17,23 +17,33 @@ use nest::{Class, NEST, NestLock};
 use anyhow::Context;
 use bytesize::ByteSize;
 
-const DIR_TARGET: LazyLock<PathBuf> = LazyLock::new(|| PathBuf::from("target/"));
-const DIR_SRC: LazyLock<PathBuf> = LazyLock::new(|| PathBuf::from("src/"));
-/// Cannot flatten this dir out of existence due to IDEs, Linters,
-/// and probably also Java expecting it to exist.
+pub static PROJECT_ROOT: LazyLock<PathBuf> = LazyLock::new(|| {
+    // Start from CWD
+    let cwd = std::env::current_dir().expect("Failed to get current working directory");
+    let mut probe = cwd.clone();
+
+    while !probe.join(F_NEST_TOML.as_path()).exists() {
+        if !probe.pop() {
+            // This is easier than having a Result everywhere. For now.
+            panic!(
+                "No {} found in current directory or any ancestor. (cwd: {})",
+                F_NEST_TOML.display(),
+                cwd.display()
+            )
+        }
+    }
+
+    probe
+});
+
+const DIR_TARGET: LazyLock<PathBuf> = LazyLock::new(|| PROJECT_ROOT.join("target/"));
+const DIR_SRC: LazyLock<PathBuf> = LazyLock::new(|| PROJECT_ROOT.join("src/"));
 const DIR_MAIN: LazyLock<PathBuf> = LazyLock::new(|| DIR_SRC.join("main/"));
-/// Once again, I would love to pull this out of src/ and into parent, but
-/// I can't do that due to IDEs, linters, and probably also Java expecting it to exist in src/.
 const DIR_TEST: LazyLock<PathBuf> = LazyLock::new(|| DIR_SRC.join("test/"));
 
 const F_NEST_TOML: LazyLock<PathBuf> = LazyLock::new(|| PathBuf::from("Nest.toml"));
 const F_NEST_LOCK: LazyLock<PathBuf> = LazyLock::new(|| PathBuf::from("Nest.lock"));
 
-/// This may not actually be the project root.
-pub static PROJECT_ROOT: LazyLock<Mutex<PathBuf>> = LazyLock::new(|| {
-    Mutex::new(std::env::current_dir().expect("Failed to get current working directory"))
-});
-
 fn main() -> anyhow::Result<()> {
     // Ensure that Nest.toml exists, if the requested command depends upon it.
     if CONFIG.command.depends_on_nest() && NEST.is_err() {
@@ -70,23 +80,18 @@ fn main() -> anyhow::Result<()> {
 }
 
 fn init() -> anyhow::Result<()> {
-    let is_empty = std::fs::read_dir(PROJECT_ROOT.lock().expect("Failed to lock mutex").as_path())
-        .is_ok_and(|tree| tree.count() == 0);
+    let cwd = std::env::current_dir()?;
 
-    let project_name = PROJECT_ROOT
-        .lock()
-        .expect("Failed to lock mutex")
+    let is_empty = std::fs::read_dir(cwd.as_path()).is_ok_and(|tree| tree.count() == 0);
+
+    let project_name = cwd
         .file_name()
         .context("Invalid directory name")?
         .to_str()
         .context("Unable to convert OsStr to str")?
         .to_owned();
 
-    // Make src, target, tests
-    for dir in [DIR_SRC, DIR_MAIN, DIR_TARGET, DIR_TEST] {
-        std::fs::create_dir_all(dir.clone())?;
-    }
-
+    // ORDER MATTERS. THIS MUST COME FIRST.
     // Make config file.
     if let Result::Ok(mut f) = OpenOptions::new()
         .write(true)
@@ -120,6 +125,11 @@ fn init() -> anyhow::Result<()> {
         )?;
     }
 
+    // Make src, target, tests
+    for dir in [DIR_SRC, DIR_MAIN, DIR_TARGET, DIR_TEST] {
+        std::fs::create_dir_all(dir.clone())?;
+    }
+
     // Make src/main/Main.java
     if let Result::Ok(mut f) = OpenOptions::new().write(true).create_new(is_empty).open(
         DIR_MAIN
@@ -130,14 +140,14 @@ fn init() -> anyhow::Result<()> {
         f.write_all(include_bytes!("../assets/src/main/Main.java"))?;
     }
 
-    // Make src/test/Main.java
+    // Make src/test/MainTest.java
     if let Result::Ok(mut f) = OpenOptions::new().write(true).create_new(is_empty).open(
         DIR_TEST
             .clone()
-            .join("Main")
+            .join("MainTest")
             .with_extension(JAVA_EXT_SOURCE),
     ) {
-        f.write_all(include_bytes!("../assets/src/test/Main.java"))?;
+        f.write_all(include_bytes!("../assets/src/test/MainTest.java"))?;
     }
 
     // git init .
@@ -154,7 +164,7 @@ fn init() -> anyhow::Result<()> {
         f.read_to_string(&mut buf)?;
 
         for ignored in [
-            DIR_TARGET.as_path().display().to_string(),
+            format!("{}/", DIR_TARGET.file_name().unwrap().display()),
             format!("*.{}", JAVA_EXT_CLASS),
         ] {
             if !buf.contains(&ignored) {
@@ -167,23 +177,22 @@ fn init() -> anyhow::Result<()> {
 }
 
 fn new(project_name: String) -> anyhow::Result<()> {
-    let cwd = PROJECT_ROOT
-        .lock()
-        .expect("Failed to lock mutex")
-        .join(project_name);
+    let cwd = std::env::current_dir()?.join(project_name);
 
     std::fs::create_dir(&cwd)?;
     std::env::set_current_dir(&cwd)?;
 
-    // Replace PathBuf within mutex
-    let mut state = PROJECT_ROOT.lock().expect("Failed to lock mutex");
-    *state = std::env::current_dir().expect("Failed to change current working directory");
-
     Ok(())
 }
 
 fn build() -> anyhow::Result<()> {
-    let mut targets = crate::fs::expand_files(DIR_SRC.as_path())?;
+    let mut targets: Vec<PathBuf> = crate::fs::expand_files(DIR_SRC.as_path())?
+        .into_iter()
+        .filter(|f| {
+            f.extension()
+                .is_some_and(|ext| ext.to_str().is_some_and(|ext| ext == JAVA_EXT_SOURCE))
+        })
+        .collect();
     let mut nest_lock = NestLock::load().unwrap_or_default();
 
     nest_lock.update();
@@ -231,7 +240,7 @@ fn run<P: AsRef<Path>>(
     // JRE pathing will be messed up without this.
     crate::env::set_cwd(DIR_TARGET.as_path())?;
 
-    java::JVMBuilder::new()
+    java::JVMBuilder::new(DIR_TARGET.as_path())
         .assertions(assertions)
         .monitor(true)
         .build()
@@ -246,33 +255,18 @@ fn test(assertions: bool) -> anyhow::Result<(Option<String>, Option<String>)> {
         .compile(DIR_TEST.as_path())?;
 
     // Change cwd to avoid Java pathing issues.
-    crate::env::set_cwd(
-        PROJECT_ROOT
-            .lock()
-            .expect("Failed to lock mutex")
-            .join(DIR_TARGET.as_path()),
-    )?;
+    crate::env::set_cwd(DIR_TARGET.as_path())?;
 
-    java::JVMBuilder::new()
+    java::JVMBuilder::new(DIR_TARGET.as_path())
         .assertions(assertions)
         .ram_min(ByteSize::mib(128))
         .ram_max(ByteSize::mib(512))
         .monitor(true)
         .build()
-        .run(DIR_TEST.as_path())
+        .run(DIR_TARGET.as_path())
 }
 
 fn clean() {
-    let _ = std::fs::remove_file(
-        PROJECT_ROOT
-            .lock()
-            .expect("Failed to lock mutex")
-            .join(F_NEST_LOCK.as_path()),
-    );
-    let _ = std::fs::remove_dir_all(
-        PROJECT_ROOT
-            .lock()
-            .expect("Failed to lock mutex")
-            .join(DIR_TARGET.as_path()),
-    );
+    let _ = std::fs::remove_file(PROJECT_ROOT.join(F_NEST_LOCK.as_path()));
+    let _ = std::fs::remove_dir_all(DIR_TARGET.join("/*").as_path());
 }

src/nest.rs

@@ -11,14 +11,8 @@ use anyhow::Context;
 use semver::Version;
 use serde::{Deserialize, Serialize};
 
-pub static NEST: LazyLock<anyhow::Result<Nest>> = LazyLock::new(|| {
-    Nest::try_from(
-        PROJECT_ROOT
-            .lock()
-            .expect("Failed to lock mutex")
-            .join(F_NEST_TOML.as_path()),
-    )
-});
+pub static NEST: LazyLock<anyhow::Result<Nest>> =
+    LazyLock::new(|| Nest::try_from(PROJECT_ROOT.join(F_NEST_TOML.as_path())));
 
 #[derive(Debug, Clone, Deserialize, Serialize)]
 pub struct Nest {
@@ -133,16 +127,12 @@ impl Class {
         // If the source file exists, hasn't been moved to a package (path is a file) and
         // the associated compiled class file exists in DIR_TARGET
         PROJECT_ROOT
-            .lock()
-            .expect("Failed to lock mutex")
             .join(DIR_TARGET.as_path())
             .join(self.name.as_path())
             .with_extension(JAVA_EXT_CLASS)
             .exists()
             && sha256::try_digest(
                 PROJECT_ROOT
-                    .lock()
-                    .expect("Failed to lock mutex")
                     .join(if self.test {
                         DIR_TEST.clone()
                     } else {